fix(progressbar): bs4 progressbar wip #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2037 +/- ##
===============================================
+ Coverage 87.16% 87.83% +0.66%
===============================================
Files 85 85
Lines 2259 2375 +116
Branches 292 320 +28
===============================================
+ Hits 1969 2086 +117
- Misses 187 190 +3
+ Partials 103 99 -4
Continue to review full report at Codecov.
|
|
Tested, looks good |
valorkin
commented
Jul 18, 2017
|
|
||
| <small><em>No animation</em></small> | ||
| <progress class="progress progress-success" [value]="dynamic" [max]="100"><b>{{dynamic}}%</b></progress> | ||
| <progressbar class="progress progress-success" [value]="dynamic" [max]="100" [type]="'success'"><b>{{dynamic}}%</b></progressbar> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
src/modal/modal.component.ts
Outdated
| @@ -69,8 +69,8 @@ export class ModalDirective implements AfterViewInit, OnDestroy { | |||
| protected originalBodyPadding: number = 0; | |||
| protected scrollbarWidth: number = 0; | |||
|
|
|||
| protected timerHideModal: number = 0; | |||
| protected timerRmBackDrop: number = 0; | |||
| protected timerHideModal: any = 0; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
src/progressbar/bar.component.ts
Outdated
| @@ -28,6 +29,10 @@ export class BarComponent implements OnInit, OnDestroy { | |||
| public get value():number { | |||
| return this._value; | |||
| } | |||
| @HostBinding('style.width.%') get setBarWidth(){ | |||
| this.recalculatePercentage(); | |||
| return this.isBs3 ? 'auto' : this.percent; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @Input() public value:number; | ||
| /** current value of progress bar. Could be a number or array of objects like {"value":15,"type":"info","label":"15 %"} */ | ||
| @Input() public set value(value: number | any[]) { | ||
| this.stacked = Array.isArray(value); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.